Skip to content

gh-138516: fix typo in OrderedDict exception msg #138517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 5, 2025
Merged

gh-138516: fix typo in OrderedDict exception msg #138517

merged 1 commit into from
Sep 5, 2025

Conversation

@asas1asas200
Copy link
Contributor

@asas1asas200 asas1asas200 commented Sep 5, 2025 •
edited
Loading

  • Remove trailing s in exception message of collections.OrderedDict.

@python-cla-bot
Copy link

python-cla-bot bot commented Sep 5, 2025 •
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app
Copy link

bedevere-app bot commented Sep 5, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app bedevere-app bot mentioned this pull request Sep 5, 2025
Closed
StanFromIreland
StanFromIreland reviewed Sep 5, 2025
View reviewed changes
Copy link
Member

@StanFromIreland StanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This qualifies for a blurb.

@kumaraditya303
Copy link
Contributor

kumaraditya303 commented Sep 5, 2025

This qualifies for a blurb.

I don't think so, it is a small typo fix.

@kumaraditya303 kumaraditya303 merged commit e9c2a35 into python:main Sep 5, 2025
55 checks passed
@kumaraditya303 kumaraditya303 added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Sep 5, 2025
@miss-islington-app
Copy link

miss-islington-app bot commented Sep 5, 2025

Thanks @asas1asas200 for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

miss-islington-app bot commented Sep 5, 2025

Thanks @asas1asas200 for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 5, 2025
@asas1asas200 @miss-islington
pythongh-138516: fix typo in OrderedDict exception msg (pythonGH-138517)
3f5927e 
(cherry picked from commit e9c2a35)

Co-authored-by: asas1asas200 <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 5, 2025
@asas1asas200 @miss-islington
pythongh-138516: fix typo in OrderedDict exception msg (pythonGH-138517)
54c2523 
(cherry picked from commit e9c2a35)

Co-authored-by: asas1asas200 <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Sep 5, 2025

GH-138522 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Sep 5, 2025
@bedevere-app
Copy link

bedevere-app bot commented Sep 5, 2025

GH-138523 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Sep 5, 2025
kumaraditya303 pushed a commit that referenced this pull request Sep 5, 2025
@miss-islington @asas1asas200
[3.13] gh-138516: fix typo in OrderedDict exception msg (GH-138517) (#…
f0756f8 
…138522)

gh-138516: fix typo in OrderedDict exception msg (GH-138517)
(cherry picked from commit e9c2a35)

Co-authored-by: asas1asas200 <[email protected]>
hugovk pushed a commit that referenced this pull request Sep 5, 2025
@miss-islington @asas1asas200
[3.14] gh-138516: fix typo in OrderedDict exception msg (GH-138517) (#…
5086a1e 
…138523)

gh-138516: fix typo in OrderedDict exception msg (GH-138517)
(cherry picked from commit e9c2a35)

Co-authored-by: asas1asas200 <[email protected]>
kumaraditya303 pushed a commit to miss-islington/cpython that referenced this pull request Sep 9, 2025
@miss-islington @asas1asas200 @kumaraditya303
[3.14] pythongh-138516: fix typo in OrderedDict exception msg (python…
fbb086d 
…GH-138517) (python#138523)

pythongh-138516: fix typo in OrderedDict exception msg (pythonGH-138517)
(cherry picked from commit e9c2a35)

Co-authored-by: asas1asas200 <[email protected]>
lkollar pushed a commit to lkollar/cpython that referenced this pull request Sep 9, 2025
@asas1asas200 @lkollar
pythongh-138516: fix typo in OrderedDict exception msg (python#138517)
f95238f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StanFromIreland StanFromIreland StanFromIreland left review comments

@aisk aisk aisk approved these changes

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@asas1asas200 @kumaraditya303 @aisk @StanFromIreland @skirpichev